Skip to content
This repository was archived by the owner on Jun 13, 2023. It is now read-only.

Conversation

@flovilmart
Copy link
Contributor

No description provided.

@flovilmart flovilmart requested review from a team and montymxb December 4, 2017 05:35
@montymxb
Copy link

montymxb commented Dec 5, 2017

This looks okay at first glance here. I'm a bit short on time but I'm leaving my review still pending so I'll get to it later tonight when I can read into the travis.yml in detail.

@flovilmart
Copy link
Contributor Author

No problem! No rush!

- |
set -o pipefail
xcodebuild build -workspace ParseLiveQuery.xcworkspace -sdk macosx -scheme ParseLiveQuery-OSX -configuration Debug GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=YES GCC_GENERATE_TEST_COVERAGE_FILES=YES | xcpretty -c
after_success: bash <(curl -s https://codecov.io/bash)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an identical after_success call above, but in a separate test stage for a separate environment. Is there a way to consolidate these two declarations of stage test with different scripts depending on the environment, but the same after_success result?

Copy link

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright this looks good 👍 . The one nit is trivial and not really that important given in the overall scheme here. Something we can adjust later on (if we can that is).

@flovilmart
Copy link
Contributor Author

I can have a look at consolidating the test steps later indeed

@flovilmart flovilmart merged commit b4c2a17 into master Dec 5, 2017
@flovilmart flovilmart deleted the jazzy-docs branch December 5, 2017 12:46
@montymxb
Copy link

montymxb commented Dec 5, 2017

My thoughts exactly 👍 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants